Make the client library separate for much smaller install #178
Comments
43081j
added a commit
to 43081j/react-scan
that referenced
this issue
Jan 17, 2025
Removes unused dependencies from the `scan` package: - `@babel/generator` - not used - `@clack/core` - not used directly, already pulled in via `@clack/prompts` - `estree-walker` - not used - `tsx` - not used At the root of the monorepo: - `@vercel/style-guide` - doesn't seem to be referenced anywhere Also changes a couple of FS paths to use `__dirname` in case `tsup` is ever run from another `cwd`. This should drop a big chunk of the install size, re aidenybai#178. This is thanks to removing `tsx` mostly, which itself is ~400KB.
43081j
added a commit
to 43081j/react-scan
that referenced
this issue
Jan 17, 2025
Removes unused dependencies from the `scan` package: - `@babel/generator` - not used - `@clack/core` - not used directly, already pulled in via `@clack/prompts` - `estree-walker` - not used - `tsx` - not used At the root of the monorepo: - `@vercel/style-guide` - doesn't seem to be referenced anywhere Also changes a couple of FS paths to use `__dirname` in case `tsup` is ever run from another `cwd`. This should drop a big chunk of the install size, re aidenybai#178. Specifically since we drop `tsx` which is ~400KB.
|
This is a priority for us in the next release |
RobPruzan
added a commit
that referenced
this issue
Jan 18, 2025
Removes unused dependencies from the `scan` package: - `@babel/generator` - not used - `@clack/core` - not used directly, already pulled in via `@clack/prompts` - `estree-walker` - not used - `tsx` - not used At the root of the monorepo: - `@vercel/style-guide` - doesn't seem to be referenced anywhere Also changes a couple of FS paths to use `__dirname` in case `tsup` is ever run from another `cwd`. This should drop a big chunk of the install size, re #178. Specifically since we drop `tsx` which is ~400KB. Co-authored-by: RobPruzan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One.js is now shipping React scan, but it massively increases or npm install size. And since we use it for both our runtime and as our CLI install (npx one) it slows down getting started a lot too.
This is because there’s a bunch of backend type dops included like playwright.
Creating a new “@react-scan/client” library would greatly help this. Would love to see this, or we may need to split it out into a separate plugin until then. I can maybe help a bit with the initial split if you are strapped for time.
The text was updated successfully, but these errors were encountered: