Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIP-158] Pagination: page_size should throw an error when it exceeds maximum acceptable value. #1428

Open
ritesh-goog opened this issue Oct 2, 2024 · 0 comments

Comments

@ritesh-goog
Copy link

This is w.r.t. guidance for Pagination (AIP-158).

Currently, is says:

If the user specifies page_size greater than the maximum permitted by the API, the API should coerce down to the maximum permitted page size.

This doesn't seem right. We should throw INVALID_ARGUMENT error if the page_size is present and is greater than the maximum value permitted by the API (similar to when page size is less than 0).

@ritesh-goog ritesh-goog changed the title Pagination: page_size should throw an error when it exceeds maximum acceptable value. [AIP-158] Pagination: page_size should throw an error when it exceeds maximum acceptable value. Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant