Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linker flags error in cxx_library and "-I $(location //targets:myrule)" preprocessor flags #149

Open
hendych opened this issue Mar 25, 2021 · 0 comments

Comments

@hendych
Copy link

hendych commented Mar 25, 2021

Hi guys, I have 2 issues in buck_local project generation.

1. cxx_library rule is not included in linker flags BuckLocal/BUCK. This mapping caused compiler error (missing symbol) when I used cxx_library rule.

Current

cxx_library() not included in linker flags BuckLocal/BUCK

Expected

library gets linked in BuckLocal/BUCK
Screen Shot 2021-03-25 at 13 43 44

2. Some of my rules are using preprocessor_flag = ["-I $(location //targets:myrule)"]. Somehow this gets filtered in the query and included in linker flags.

Current

Screen Shot 2021-03-25 at 13 39 28

Caused by
Screen Shot 2021-03-25 at 13 41 47

Expected

string "-lct#iphonesimulator-x86_64,private-headers.hm" not included in linker flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant