From 0f9f7444e4648d23a1a43379cb6cfe4e6463cd38 Mon Sep 17 00:00:00 2001 From: 9toon Date: Tue, 23 Feb 2021 14:33:14 +0900 Subject: [PATCH 1/5] Update supported Ruby versions * Drop support Ruby <= 2.4 because their statuses are EOL. * Add support Ruby 2.5, 2.6, 2.7 --- .travis.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index a5b84b9..f9a2431 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,11 +2,9 @@ language: ruby sudo: false cache: bundler rvm: - - "1.9.3" - - "2.0" - - "2.1" - - "2.2" - - "2.3.3" + - "2.5" + - "2.6" + - "2.7" before_install: - gem update bundler script: From c7f9dc9fab1f7abfd347cc10573948b3fabd6d34 Mon Sep 17 00:00:00 2001 From: 9toon Date: Tue, 23 Feb 2021 14:39:12 +0900 Subject: [PATCH 2/5] Support faraday 1.x --- hypernova.gemspec | 2 +- spec/faraday_connection_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hypernova.gemspec b/hypernova.gemspec index c2e9e2f..de2136d 100644 --- a/hypernova.gemspec +++ b/hypernova.gemspec @@ -46,5 +46,5 @@ Gem::Specification.new do |spec| # see https://github.com/weppos/publicsuffix-ruby/issues/127 spec.add_development_dependency "public_suffix", "=1.4.6" - spec.add_runtime_dependency "faraday", "~> 0.8" + spec.add_runtime_dependency "faraday", "~> 1" end diff --git a/spec/faraday_connection_spec.rb b/spec/faraday_connection_spec.rb index c6b4073..3718c80 100644 --- a/spec/faraday_connection_spec.rb +++ b/spec/faraday_connection_spec.rb @@ -21,7 +21,7 @@ }). and_call_original - expect(described_class.build.builder.handlers).to include(Faraday::Adapter::NetHttp) + expect(described_class.build.builder.adapter).to eq(Faraday::Adapter::NetHttp) end end end From 36f1f90fb622d60c108ca782ebd4b9b774af2d4f Mon Sep 17 00:00:00 2001 From: 9toon Date: Tue, 23 Feb 2021 15:38:43 +0900 Subject: [PATCH 3/5] Update webmock(~> 3.0) to fix an incompatibility with faraday-1.x --- hypernova.gemspec | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hypernova.gemspec b/hypernova.gemspec index de2136d..f872cab 100644 --- a/hypernova.gemspec +++ b/hypernova.gemspec @@ -38,9 +38,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency "rspec", "~> 3.4" spec.add_development_dependency "simplecov", "~> 0.11" spec.add_development_dependency "pry", "~> 0.10" - # this is pinned because ruby devs hate semver - # see https://github.com/bblimke/webmock/issues/667 - spec.add_development_dependency "webmock", "=2.1.0" + spec.add_development_dependency "webmock", "~> 3.0" # below works around travis-ci requiring github-pages-health-check, whose subdep public_suffix # stopped being compatible with ruby 1.9 # see https://github.com/weppos/publicsuffix-ruby/issues/127 From dc79f45f5b139729bbadc7ffd94591a78addfc30 Mon Sep 17 00:00:00 2001 From: 9toon Date: Tue, 23 Feb 2021 15:39:54 +0900 Subject: [PATCH 4/5] Do not specify "json" gem's version Because json-1.8.x gem produces a deprecation warning on Ruby 2.7. see: https://github.com/flori/json/issues/399 --- hypernova.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hypernova.gemspec b/hypernova.gemspec index f872cab..3595b76 100644 --- a/hypernova.gemspec +++ b/hypernova.gemspec @@ -33,7 +33,7 @@ Gem::Specification.new do |spec| spec.metadata["allowed_push_host"] = 'https://rubygems.org' end - spec.add_development_dependency "json", "~> 1.8" + spec.add_development_dependency "json" spec.add_development_dependency "rake", "~> 10.0" spec.add_development_dependency "rspec", "~> 3.4" spec.add_development_dependency "simplecov", "~> 0.11" From 1f86160584ba284d4188d4cb8287ea9451f1a196 Mon Sep 17 00:00:00 2001 From: 9toon Date: Tue, 23 Feb 2021 15:44:58 +0900 Subject: [PATCH 5/5] Drop public_suffix from dependencies because we don't support Ruby1.9 --- hypernova.gemspec | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hypernova.gemspec b/hypernova.gemspec index 3595b76..bcc37f4 100644 --- a/hypernova.gemspec +++ b/hypernova.gemspec @@ -39,10 +39,6 @@ Gem::Specification.new do |spec| spec.add_development_dependency "simplecov", "~> 0.11" spec.add_development_dependency "pry", "~> 0.10" spec.add_development_dependency "webmock", "~> 3.0" - # below works around travis-ci requiring github-pages-health-check, whose subdep public_suffix - # stopped being compatible with ruby 1.9 - # see https://github.com/weppos/publicsuffix-ruby/issues/127 - spec.add_development_dependency "public_suffix", "=1.4.6" spec.add_runtime_dependency "faraday", "~> 1" end