Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify this plugin #29

Open
frantz45 opened this issue Jul 19, 2022 · 0 comments
Open

Simplify this plugin #29

frantz45 opened this issue Jul 19, 2022 · 0 comments

Comments

@frantz45
Copy link
Collaborator

Actually the plugin has 2 threshold types (more/less than), 2 streams and multiple time conditions (any/before/after).
It makes the code complex.

Regarding the time conditions we could only keep before or after but not both (just invert the streams if you want the opposite order).

Regarding the threshold types we could only keep "more than".
It's the most meaningful type regarding detection rules.
"Less than" is mainly use with the "any" time condition to create exceptions.
This last use case could be moved to another new plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant