Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[source-instagram] Missing option to specify Client ID and Client Secret for OAuth in Airbyte OSS #53158

Closed
1 task
abtal opened this issue Feb 4, 2025 · 4 comments · Fixed by #53171
Closed
1 task

Comments

@abtal
Copy link

abtal commented Feb 4, 2025

Connector Name

source-instagram

Connector Version

3.1.4

What step the error happened?

Configuring a new connector

Relevant information

While setting up the Instagram connector in Airbyte OSS self-hosted, there is no option to specify the Client ID and Client Secret for OAuth authentication.

Image

Relevant log output

Contribute

  • Yes, I want to contribute
@marcosmarxm
Copy link
Member

Thanks for reporting this @abtal I raised the problem to team take a look.

@natikgadzhi
Copy link
Contributor

Might be a bug — we expect sources that Airbyte does not set secrets explicitly for to have the ability to set them from the user. This form clearly does not have those.

First good step is to have a local repro with abctl on Airbyte 1.4 specifically for this source.

@bazarnov
Copy link
Collaborator

bazarnov commented Feb 4, 2025

It happens to be true that OSS comes alongside the OAuth Classes we have for the platform as Legacy code, meaning that we are covering the implementation for the legacy as it was before the DeclarativeOAuthFlow.

To fix this, we must either:

  • migrate from legacy, modify the source to support the declarative oauth, and release another OSS version
  • modify how UI treats the OSS deployment and have a fork for the same logic to cover the case when we already have the Legacy implementation, but it's OSS, and there are no instance-wide parameters added to the OSS Instance yet.

P.S.: The problem is that we have the Legacy OAuth Implementation that prevents the UI from drawing the client_id / client_secret fields correctly.

@bazarnov
Copy link
Collaborator

bazarnov commented Feb 4, 2025

Note:

  • we are not ready to migrate the Meta-related sources to the DeclarativeOAuthFLow yet because of this additional request logic is not covered in the current release.
  • we are ready to move everything else to the DOAF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants