Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible mistake in NACA 4-digit series geometry creation #2

Open
jsaldia opened this issue Jan 6, 2021 · 2 comments
Open

possible mistake in NACA 4-digit series geometry creation #2

jsaldia opened this issue Jan 6, 2021 · 2 comments

Comments

@jsaldia
Copy link

jsaldia commented Jan 6, 2021

it is possible that Lines 131 to 132 of airfoils.py should be changed to
p = float(naca_digits[1])/10
m = float(naca_digits[0])/100
to complain with NACA 4-digit series designation

@jsaldia jsaldia changed the title possible mistake in NACA Series-4 geometry creation possible mistake in NACA 4-digit series geometry creation Jan 6, 2021
@jphkun
Copy link

jphkun commented Mar 23, 2021

Hi jsaldia,

I have looked into it and it looks like you were correct. I have implemented the changes in my version, but I want to discuss the results with Aaron before merging the code. If that can help I have compared the results with the ones obtained from http://www.airfoiltools.com/airfoil/naca4digit.

At the moment there is still a significant difference between the module and the website results (error of 1e-2), for extreme cases like a for the NACA9930 wing. Classical NACA profiles like the 00xx, 14xxx, 24xx and 64xx series should be precise enough to work with.

@DavidAnderegg
Copy link

This is probably related to this.

When i create a NACA0002 with 125 points in x-direction (cos spacing), i get this (zoomed in on the LE):
is
But it should look like this:
should

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants