MAINT: Possible redundant code in util.which()

[refack]

IIUC most of

asv/asv/util.py

Lines 200 to 232 in 4c31eda

	__tracebackhide__ = operator.methodcaller('errisinstance', OSError)
	if os.path.sep in filename:
	locations = ['']
	elif paths is not None:
	locations = paths
	else:
	locations = os.environ.get("PATH", "").split(os.pathsep)
	if WIN:
	# On windows, an entry in %PATH% may be quoted
	locations = [path[1:-1] if len(path) > 2 and path[0] == path[-1] == '"' else path
	for path in locations]
	if WIN:
	filenames = [filename + ext for ext in ('.exe', '.bat', '.com', '')]
	else:
	filenames = [filename]
	candidates = []
	for location in locations:
	for filename in filenames:
	candidate = os.path.join(location, filename)
	if os.path.isfile(candidate) or os.path.islink(candidate):
	candidates.append(candidate)
	if len(candidates) == 0:
	if paths is None:
	loc_info = 'PATH'
	else:
	loc_info = os.pathsep.join(locations)
	raise OSError(f"Could not find '{filename}' in {loc_info}")
	return candidates[0]

cloud be replaced with a call to shutil.which. Just need the raise semantics and temporarily fudging os.envison['PATH'] == locations.

Is there any lore about this specific implementation?

[HaoZeke]

None that I can think of, but most likely just historical baggage, shutil.which was added in 3.3 and asv used to support 2.7 for a long time.

A PR would be most welcome :)

[refack]

A PR would be most welcome :)

On it 😊