-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot identify server from metrics #183
Comments
The first part of the metrics IDs should be the server's hostname, if Java is able to figure it out. It does work for me on Windows 10 and Ubuntu 16.04, at least. I suppose it could also be made configurable. |
For example, these servers (https://zy-a.us.notrly.xyz and https://zy-a.apac.notrly.xyz) use |
It really only matters if servers with conflicting hostnames use the same kafka/postgres metrics store. Users would have to configure the name setting in the properties file if the machine's hostname isn't acceptable, but they'd have to configure that it should be doing metrics logging in the first place anyway, so I don't really see that as much additional burden. I will go ahead and make the name configurable, though. Hopefully tomorrow. |
famous last words... |
It is very difficult to identify the server that hosted a given session from just the
SessionId
. I don't know how this could be fixed; logging the server domain is too invasive?The text was updated successfully, but these errors were encountered: