Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethinking wavelength sampling and wavelengths in the synthesis API #283

Open
ajwheeler opened this issue Mar 12, 2024 · 2 comments
Open
Milestone

Comments

@ajwheeler
Copy link
Owner

ajwheeler commented Mar 12, 2024

There are two things that could be improved about the way wavelengths are currently handled.

  1. Log-uniform wavelengths (uniform velocity steps) provide a better sampling for broad wavelength ranges. It makes for much saner calculations from the UV to the IR, and makes, e.g. Synthetic photometry #261 easier/faster. It also makes convolutions with velocity kernels really mathematically nice, and potentially faster using FFTs.
  2. Having to pass a vector of Julia ranges in order to get non-contiguous wavelength ranges is a big pain if you are using python.

My current thinking is that this is worth doing, but I'm going to let the idea cure for a bit.

@ajwheeler
Copy link
Owner Author

This will be closed by #336, if it's merged.

@ajwheeler ajwheeler added this to the 1.0 milestone Oct 5, 2024
@ajwheeler
Copy link
Owner Author

I'm leaving this open for now. #336 does most of this, but doesn't make all the breaking changes that are required for me to move to log-uniform wavelength sampling without anyone noticing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant