Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DXE-4666 [ENHANCEMENT] Remove pyOpenSSL #79

Open
jumpifnotzero opened this issue Jan 27, 2025 · 1 comment
Open

DXE-4666 [ENHANCEMENT] Remove pyOpenSSL #79

jumpifnotzero opened this issue Jan 27, 2025 · 1 comment

Comments

@jumpifnotzero
Copy link

Describe the solution you'd like
pip install egdegrid-python should not install pyOpenSSL and its dependencies. I'd recommend removing it as noted below, however an optional dependency would suffice if necessary for backwards compatibility.

Additional context
The pyOpenSSL module for urllib3 is no longer recommended.

It appears the requirement to force use of pyopenssl was introduced in release 1.0.7. That release is nearly 10 years old, and it seems recommended practice has moved on as noted above.

From requirements.txt, it seems you will also need to remove ndg-httpsclient to remove pyOpenSSL. I did not find any references to this package - perhaps it is a dev dependency.

@lsadlon lsadlon changed the title [ENHANCEMENT] Remove pyOpenSSL DXE-4666 [ENHANCEMENT] Remove pyOpenSSL Jan 28, 2025
@lsadlon
Copy link

lsadlon commented Jan 28, 2025

Hi @jumpifnotzero

Thanks for reporting this issue. We will investigate it and go back to you.

BR,
Lukasz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants