Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: improve freight discovery error tooltip #2582

Open
3 of 4 tasks
Marvin9 opened this issue Sep 26, 2024 · 4 comments
Open
3 of 4 tasks

ui: improve freight discovery error tooltip #2582

Marvin9 opened this issue Sep 26, 2024 · 4 comments
Assignees
Labels
area/ui good first issue Good issue for a new contributor to handle kind/bug priority/normal
Milestone

Comments

@Marvin9
Copy link
Contributor

Marvin9 commented Sep 26, 2024

Checklist

  • I've searched the issue queue to verify this is not a duplicate bug report.
  • I've included steps to reproduce the bug.
  • I've pasted the output of kargo version.
  • I've pasted logs, if applicable.

Description

When Warehouse couldn't discover one of freight, it shows an error inside tooltip in the UI. However the error is not readable directly, needs to scroll. Also there seems 2 scrollbars and redundant icons.

Screenshots

Screenshot 2024-09-26 at 2 31 13 PM (2)

Steps to Reproduce

Create invalid freight

Version

dev

Logs

Paste any relevant application logs here.
@Marvin9 Marvin9 added kind/bug good first issue Good issue for a new contributor to handle area/ui labels Sep 26, 2024
@krancour krancour added this to the v0.10.0 milestone Sep 26, 2024
@chbg
Copy link

chbg commented Sep 27, 2024

Hi! I’d like to work on this issue.

To fix the scrolling problem with error tooltips, I’m thinking of modifying the tooltip’s design. This could involve adjusting the tooltip’s max-height and setting overflow properties to ensure all content is visible without scrolling. Alternatively, we could explore truncating the message with an option to expand for more details.

Could I be assigned this issue?

Thanks!

@Marvin9
Copy link
Contributor Author

Marvin9 commented Sep 27, 2024

Sure, assigned to you @chbg.

@krancour krancour modified the milestones: v1.0.0, v1.1.0 Oct 18, 2024
@ddeath
Copy link
Contributor

ddeath commented Oct 25, 2024

Note that if you try to copy it so you can paste it somewhere, it will open Freight detail if you click on it. Imho it should not open details page if you click on tooltip.

@krancour
Copy link
Member

krancour commented Oct 25, 2024

The tooltip is nice and all and I wouldn't suggest we remove it, and I do believe it can be improved, but I think displaying error messages clearly in the Warehouse details view would probably make it quite a bit easier for people to read and copy if necessary.

For reference, Promotions currently do this. The prominently display whatever error prevented them from succeeding in the details view.

@krancour krancour modified the milestones: v1.1.0, v1.2.0 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui good first issue Good issue for a new contributor to handle kind/bug priority/normal
Projects
None yet
Development

No branches or pull requests

4 participants