Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to map users git email address to a user name for easier understanding who made the change. #3404

Open
kencochrane opened this issue Jan 29, 2025 · 2 comments

Comments

@kencochrane
Copy link
Contributor

Proposed Feature

The list of emails in the "Created By" column on the stage details page seems to be coming from the git commits. It would be nice if there were a way to map these git emails to users and display the user's names in case some of the emails aren't obvious who they are. You could still show the emails if needed (Maybe when you hover over, or click on an "i" icon)

Image

Motivation

Make it created by list more user-friendly and easier to use when someone has weird email addresses for their git commits. This will also make it easier if someone commits code from multiple email addresses.

Suggested Implementation

None

@krancour
Copy link
Member

@kencochrane those aren't coming from a commit, but from claims in the ID token of the authenticated user who manually triggered the Promotion. In the case of an auto-promotion, it will show up as "N/A".

Current logic seems to prefer the email claim, followed by the sub claim. Then it gives up if neither of those are found. But those are standard claims, so in practice, it is probably always email.

GitHub user handles would be nice, but we'd only have a claim with that info if GitHub is the IDP.

Since many useful claims (like GitHub handle) aren't standard, the best thing might be to just make it configurable which claim Kargo should use as the username.

wdyt?

@kencochrane
Copy link
Contributor Author

@krancour yeah that seems reasonable, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants