Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide PR link in git-open-pr promotion step output #3450

Open
3 of 4 tasks
Marvin9 opened this issue Feb 6, 2025 · 0 comments
Open
3 of 4 tasks

provide PR link in git-open-pr promotion step output #3450

Marvin9 opened this issue Feb 6, 2025 · 0 comments

Comments

@Marvin9
Copy link
Contributor

Marvin9 commented Feb 6, 2025

Checklist

  • I've searched the issue queue to verify this is not a duplicate bug report.
  • I've included steps to reproduce the bug.
  • I've pasted the output of kargo version.
  • I've pasted logs, if applicable.

Description

Pull request deep links are not working - #3024 (comment)

With promotion steps, UI recently changed the way it structures Pull request deep link - #3024.

It constructs URL from git-open-pr step output and config values (repoURL from step config and prNumber from output). However when the spec contains expression language, it fails to generate URL because now repoURL is not raw value.

The solution is to provide as much as info in promotion steps output (in this case, repoURL), it can be either full URL or at the very least, values that will help UI to construct link.

Screenshots

#3024 (comment)

Steps to Reproduce

  • Create stage with promotion step git-open-pr and promote to that stage
  • check the promotion lists in stage details page and open the promotion step modal. Both won't have PR deep link

Version

dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants