Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid URL causes error #14

Open
treyhuffine opened this issue May 14, 2017 · 1 comment
Open

Invalid URL causes error #14

treyhuffine opened this issue May 14, 2017 · 1 comment
Labels
help wanted

Comments

@treyhuffine
Copy link
Contributor

When the the URL is invalid, we the error Uncaught TypeError: Cannot read property 'indexOf' of null. I'll add a fix for the issue.
@alanshaw
Copy link
Owner

Yes there should be a try/catch around URL.parse that'll call the callback if an error is caught.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alanshaw @treyhuffine