File not found - *.cpp and File not found - *.c

[florinmatthew]

"File not found" running under Windows 10

[florinmatthew]

More:
g++ -std=c++11 -Wall -Wextra -Wno-unknown-pragmas -O3 -ftree-vectorize -funroll-loops -o bin/film_grain_rendering_main -lpng -ltiff
process_begin: CreateProcess(NULL, g++ -std=c++11 -Wall -Wextra -Wno-unknown-pragmas -O3 -ftree-vectorize -funroll-loops -o bin/film_grain_rendering_main -lpng -ltiff, ...) failed.
make (e=2): The system cannot find the file specified.
make: *** [bin/film_grain_rendering_main] Error 2

[ghost]

I'm also experiencing "missing" files, though I have no experience with coding so maybe I'm just doing something wrong.

C:\Users\User\Desktop\Film_grain_rendering_IPOL>make.exe
File not found - *.cpp
File not found - *.c
"===== Link bin/film_grain_rendering_main ====="
g++ -std=c++11 -Wall -Wextra -Wno-unknown-pragmas -O3 -ftree-vectorize -funroll-loops -o bin/film_grain_rendering_main -lpng -ltiff
process_begin: CreateProcess(NULL, g++ -std=c++11 -Wall -Wextra -Wno-unknown-pragmas -O3 -ftree-vectorize -funroll-loops -o bin/film_grain_rendering_main -lpng -ltiff, ...) failed.
make (e=2): The system cannot find the file specified.
make.exe: *** [bin/film_grain_rendering_main] Error 2

[alasdairnewson]

Hi there, sorry for these bugs, in fact this is a research code, so it was tested with a linux operating system. Apparently, the bugs are with windows. Can you tell me what you are using to compile the code ? As specified in the readme.txt, you need to compile the code with the makefile provided. If you do not know how makefiles work, I can discuss this directly with you rather than exchanging here.

Thanks !

[ghost]

Perhaps it is a Windows problem, that or my lack of understanding in coding (I know literally nothing as mentioned in previous emails.) I downloaded Microsoft Visual Studios 2017 to compile the code, after looking up multiple tutorials on how to run a makefile I gave up. In between different coding programs used, and how they all seemed vastly different from one another, as well as how they were coding. They demonstrated compiling the code using the "make" command to create the makefile. However, when it came to executing the makefile, that's where they all lost me. I wasn't exactly sure what they were doing. So I tried following someone's advice on a forum (I suspect Florian did the same) and ended up downloading and installing "make-3.81.exe" essentially dropping in the "make.exe" file into the folder directory of the "makefile" in your code, run the application and it creates the .exe. Then open the CMD in Visual Studios and type "make.exe" then I'm prompted with what I copy and pasted to you. How else would we discuss this further, what did you have in mind? If it isn't too much to ask, would it be possible to compile the code on a Windows machine and linking a download for the compiled code? Possibly even including a link next to the source code? Does the compiled code form an application? I'm not sure what to expect from all of this to be honest, or if I'll be able to use it as I intended. Also, thank you for the reply and assistance!

…

On Thu, Apr 26, 2018 at 3:31 AM, alasdairnewson ***@***.***> wrote: Hi there, sorry for these bugs, in fact this is a research code, so it was tested with a linux operating system. Apparently, the bugs are with windows. Can you tell me what you are using to compile the code ? As specified in the readme.txt, you need to compile the code with the makefile provided. If you do not know how makefiles work, I can discuss this directly with you rather than exchanging here. Thanks ! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ak8IKteP0jC4jdn9mp8WNcd_uA4YSRLYks5tsXfAgaJpZM4PLKrE> .

[alasdairnewson]

Hi ! Yes, compiling with windows can often be a pain, which is why many people use linux for this purpose. In linux, you just open a terminal and type 'make', and if you have the necessary libraries, everything is good, you get an executable.

What I would suggest is to install the 'cygwin' program, I think that is the best option.
https://www.cygwin.com/install.html

This imitates linux in windows. If you can do this, then you should be able to just go to the correct directory and simply type 'make'. You will have to install libpng and libtiff, but I can help you with that.

Let me know if you have correctly installed cygwin.

Otherwise I will try and find a windows installation to compile the code.

[ghost]

Sorry for late response, It was 3:30 am when I'd emailed you back. Anyways, I've downloaded and installed Cygwin, as well as​ LibPNG and LibTIFF. As you said, they're needed to compile the makefile, as I tried doing without installation of PNG and TIFF. How do I install both LibTIFF/PNG so I can compile the makefile? Edit: I opened the directory for "tiff-4.0.9" and ran "./configure". It created the "tiffconf.n" file that was needed, however I'm clueless as how to obtain the "pnglibconf.h" file. I'm using Visual Studios 2017 on Windows 10, I'm missing the folder directories presented in this video tutorial. https://www.youtube.com/watch?v=GsgSnSG0O0U&t=3s

[alasdairnewson]

Hi ! Could you go to the root directory of the code (the directory where you decompressed the file), and type 'make' and tell me what happens ? I will be travelling this weekend so i might not be able to get back to you straight away !

[ghost]

User@Box /cygdrive/d/users/film_grain_rendering_ipol - copy
$ make
===== Compile src/io_png.c =====
g++ -std=c++11 -Wall -Wextra -Wno-unknown-pragmas -O3 -ftree-vectorize -funroll-loops -Isrc -c src/io_png.c -o obj/io_png.o
In file included from src/io_png.c:46:0:
src/png.h:361:27: fatal error: pnglibconf.h: No such file or directory

                       ^

compilation terminated.
make: *** [makefile:48: obj/io_png.o] Error 1

As mentioned, the directories shown in that video do not exist within Visual Studios 2017. Not sure how else to obtain the file.

[alasdairnewson]

Hi again, ok, yes this means that the libpng (and libtiff) libraries are not installed. To install these in cygwin, apparently, you need to click again on the setup.exe file of cygwin, which will allow you to select certain packages:

https://cygwin.com/cygwin-ug-net/setup-net.html#setup-packages

This should install the packages, at which point you just need to do a 'make' in the code's root directory again, and it should be ok. You might have to restart cygwin after installing the packages.

[ghost]

I decided to give it another go today, I managed to get the code compiled and working. However, is the program strictly limited to using Cygwin to operate it, or is it possible to execute it as its own entity in another window (like photoshop or lightroom, etc.)? Also a few more additional questions, now that I know how to install it. When I try to input a .TIF file, I'm prompted with "unable to read the input image". I tried to process a full resolution 4000x6000 16-bit .PNG image with it, and after roughly 20 minutes it had failed to write, aside from processing times (which I expect to be lengthy,) what is the max acceptable resolution (unless that's not quantifiable)? I tried a 400x600 16-bit (I know it says 8-bit gray but I thought I'd try) .PNG and it had written successfully and produced after 1 minute, though I'm stuck to using black and white and (edit: set it to 8-bit, I can now edit full resolution) low resolutions. I swear I recalled seeing something earlier that you could change the values from 0 to 1 to get color. I just can't remember where I had seen that amongst the files, or where to place it in the chain of commands (the example given, referred to below.)

bin/film_grain_rendering_main input.tiff output.png -r "0.1" -grainSigma "0.0" -filterSigma "0.8" -zoom "2.0" -algorithmID "0" -NmonteCarlo "100"

[alasdairnewson]

Hi ! I'm glad you got the code working ! Yes, for this version, you have to use it with a command line. There is another version which has a GUI, but you would have to have QT creator installed, which I imagine you do not have if you do not code very much. I would be interesting in developing a photoshop version at some point, but it always seemed too slow for that purpose, at the moment anyway.

I think that the TIF file problem may be a very stupid bug indeed ! I think that I check whether the file has the extension '.tiff', and if not the code does not consider it to be a tiff file ... so try just renaming it to .tiff :)

I would be interested to see the file you are talking about, and to check the bug out. Could you send it to me ? I will send you an email so you can write me directly. Yes, you should be able to get colour, it should do it automatically.

[alasdairnewson]

Sorry, rectification ! You have to set -color to 1 in the command line options ! Sorry, I didn't write that in the readme, I will rectify that !

[ghost]

​ Test 8-Bit Full Resolution.tif <https://drive.google.com/file/d/1fFC8EP7YbFdkDH9BMvmhos7875tSEEs0/view?usp=drive_web> ​​ Test 16-bit Full Resolution.tif <https://drive.google.com/file/d/1ax7nC8Oh1i1YWPDLnr7NXWc4Em9_FYvJ/view?usp=drive_web> ​Included is a screenshot of the Cygwin log and files in folder. I'll attach a different file, though, one as 8-bit and 16-bit. I think a photoshop plugin would be pretty neat, granted it's a slow practice, but I'd say the payoff is worth it for that extra bit of added realism! I've tried to upload it both as 16-bit and 8-bit .tif. When uploading as ".tif" I'm prompted with: "Unable to read input image." When changing the ".tif" extension to ".tiff" (ignoring the initial dialog box warning that changing the extension could render the file as unreadable) I'm prompted with: "TIFFFetchNormalTag: Warning, Incompatible type for "RichTIFFIPTC"; tag ignored." I should add that its not one specific file, any .tif/.tiff file used I get the same message. Could it be specific to my digital camera model and/or Photoshop build, as its unsupported in Lightroom and uses the "Adobe Standard" camera profile? I also renamed the folders/.exe to "grain," just because it was easier to type out a repetitious word. Maybe I downloaded the wrong libtiff "devel" when setting up Cygwin? I think I downloaded "library 16," I think "library 12" was the other devel package. Assuming its a possibility of user error rather than code.

…

On Sun, May 20, 2018 at 11:02 AM, alasdairnewson ***@***.***> wrote: Sorry, rectification ! You have to set -color to 1 in the command line options ! Sorry, I didn't write that in the readme, I will rectify that ! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ak8IKk_qP75jnp0gKOhFA1P5K-wokRMEks5t0YWHgaJpZM4PLKrE> .