Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm audit alert being triggered - alchemy-sdk tied to 3-year-old @ethersproject/providers 5.7.2 - with ws 7.x #468

Open
respectabiggle opened this issue Nov 7, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@respectabiggle
Copy link

Sorry if this has been addressed or if I'm missing something obvious.

[REQUIRED] Environment

Win10

  • Browser version: none
  • Alchemy SDK version: 3.4.7

[REQUIRED] Describe the problem

npm audit shows

ws 7.0.0 - 7.5.9
Severity: high
ws affected by a DoS when handling a request with many HTTP headers - GHSA-3h5v-q93c-6h6q
No fix available
node_modules/@ethersproject/providers/node_modules/ws
@ethersproject/providers <=5.7.2
Depends on vulnerable versions of ws
node_modules/@ethersproject/providers
alchemy-sdk *
Depends on vulnerable versions of @ethersproject/providers
node_modules/alchemy-sdk

How to reproduce:

npm audit

Relevant code or sample repro:

all my Alchemy code works fine (thanks)

@respectabiggle respectabiggle added the bug Something isn't working label Nov 7, 2024
@doctorloaf
Copy link

This has been an ongoing issue. We previously fixed by manually updating the package-lock to the proper versions of ws and elliptic but with the 3.5.0 release it seems like the problem has returned and we have not been able to find the correct versions to override with yet.

This was supposedly fixed in 3.4.3 but we still had to do the manual override. You can see a closed issue here where we raised the problem.

#457

@LaCocoRoco
Copy link

Thanks for the help! Updated this in package-lock.json and afterwards npm install fixed the problem.

"node_modules/elliptic": {
  "version": "6.6.0",

"node_modules/ws": {
  "version": "7.5.10",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants