Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance QOL: Update build artifacts to match release names #136

Open
dreamsyntax opened this issue May 12, 2024 · 1 comment
Open

Maintenance QOL: Update build artifacts to match release names #136

dreamsyntax opened this issue May 12, 2024 · 1 comment

Comments

@dreamsyntax
Copy link
Collaborator

dreamsyntax commented May 12, 2024

Artifacts should match our release format, which includes version number

  • On tag creation, a pipeline should kick off matching the below format, which will then be used as the assets in question (automatic release is possible, bonus to look into that - this repo for example has this working - GitHub Actions performs the release on tag)
  • For PR artifacts that are non-releases / non-tagged, the short commit hash should be included
  • Optional: drop the matrix style pipeline for Windows, I don't think we need debug to run in CI.

Note: On releases we directly upload the unzipped AppImage as there is no compression savings. this can be ignored if we can't directly push as an AppImage

Current format

linux-ubuntu-22.04-appimage.zip
linux-ubuntu-22.04-binary.zip
macOS-intel.zip
windows-release.zip 

Planned Format

Release/Tagged format:

dolphin-memory-engine-1.1.1-linux-x86_64.AppImage
dolphin-memory-engine-1.1.1-macOS-intel.zip
dolphin-memory-engine-1.1.1-ubuntu-22.04-x86_64.zip
dolphin-memory-engine-1.1.1-windows-amd64.zip

PR / Non-release format, assuming the last commit is e8ea2b3 :

dolphin-memory-engine-1.1.1-e8ea2b3-linux-x86_64.AppImage
dolphin-memory-engine-1.1.1-e8ea2b3-macOS-intel.zip
dolphin-memory-engine-1.1.1-e8ea2b3-ubuntu-22.04-x86_64.zip
dolphin-memory-engine-1.1.1-e8ea2b3-windows-amd64.zip
@dreamsyntax
Copy link
Collaborator Author

Amendment: Package linux binaries in .tar.gz to preserve executable permission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant