-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font previews in some apps render incorrectly with lots of extra horizontal space #560
Comments
Congrats on the strangest bug report I've seen this week. I have no idea what this is about. Nothing in the rage Out of curiosity do you have the same results with the newly minted TTF variants, or only the OTFs? Does it affect all fonts in the family or just Libertinus Serif? |
Sorry I don't know enough about fonts to be much help. I just found this site https://fontdrop.info that gives lots of info for font files you drop on it. I happened to have old files for 7.030 on my drive as well, so I compared the Libertinus Serif Regular OTF files for both, and some of width/size values are significantly different:
Sorry again that I don't know much about how those would be set, etc., or if that might actually be what is affecting previews for me. :) |
Sorry, I missed this question. It looks like all of them except for Libertinus Mono. |
I guess there is an easy way to know if it is tooling related. I can try to regenerate v7.040 using current tooling and/or v7.051 with old tooling. |
Here are some pseudo releases to compare with:
Can you give each of these a spin and see if either/both show the same effects? |
It looks like 7.041 and 7.052 both have the same problem. I went back and downloaded the actual 7.040, and it looks fine. |
This still isn't making a bean of sense to me. The In other news though, by test above was a bit incomplete. I built v7.052 using a Fontship version from the same year that v7.040 was built, but it turns out if was from a couple months after the release. I just did another build using the actual version that would have been current at the time Libertinus shipped: What does that do for your app? |
What code point(s) should render uniE008? I'd like to see what it looks like in a text document. |
Whew, at least we got one result as a stepping stone to work from. So it's something in between Fontship v0.7.6 and Fontship v0.8.2. And probably not Fontship itself but one of the bundled tools like python-fonttools or python-sfdlib or python-sfd2ufo. There isn't much more to bisect there, the breakage almost certainly comes in with something in Fontship v0.8.0 which brought lots of updated Python tooling. Also it still isn't clear this is even a bug in the font, it might be correct behavior from the font and a bug prior, and your preview apps just don't handle the correct encoding properly. I think we have enough evidence to go on here yet, but still digging... |
UniEOO8 is in the private use area of Unicode and I have idea why there are PUA glyphs in any of the family fonts in the first place. There is a handful of random signage and flourishes and iconography in Libertinus Serif and others that (in my opinion) just doesn't need to be in a body text font family at all. |
Here is the code point if you want to try it in something: |
I just tried it out in various versions of Libertinus Serif Regular, but it doesn't seem to render in any of them when used in a text/document file. I tried on both macOS and Windows. Is it just a glyph that gets added to some other code point? |
Re uniE008: in v7.040 and v7.051 I find nothing in the Private Use Area at all, at least in the OTF version of the fonts. The original Linux Libertine fonts did have lots of glyphs there. |
Long time ago I dropped all PUA code points from the fonts, I kept the gluphs in the sources but made them unencoded so they were inaccessible, and I think I had a subsetting step that would remove any inaccessible glyphs. Either inaccessible glyphs are now kept, or something is adding codepoints back to the glyphs. |
Thanks for the helpful info! As you say, I wonder if something in the tooling change skips taking them out now, or if they get added back in. |
I think it might be caused by 9fedcbe |
Describe the bug
In some font preview apps like PopChar and Font File Browers, versions 7.050 and 7.051 of Libertinus Serif, Libertinus Sans, and Libertinus Serif Display appear with a lot of horizontal space on both sides of each glyph. In PopChar, it causes each glyph to be rendered at a very small size. See the screenshots below of Libertinus Serif Regular compared to other fonts.
Actually using the fonts in other apps and documents to compose text works fine.
Screenshots / logs
Additional context
Previous versions still display correctly in both PopChar and Font File Browser. Did anything change in the latest versions that might have affected this?
The text was updated successfully, but these errors were encountered: