You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
The battle_tag_check method in the Overwatch class incorrectly restricts the battletag ID to only 4 or 5 digits. Overwatch player IDs can sometimes be 6 digits long, so this validation fails for valid battletags with 6-digit IDs.
To Reproduce
Steps to reproduce the behavior:
Call the all_player_data method with a battletag that has a 6-digit ID, e.g., ExampleUser#123456.
Observe that the method fails to validate this correctly formatted battletag.
Expected behavior
The method should correctly validate battletags with IDs that are 4, 5, or 6 digits long. Battletags such as ExampleUser#123456 should be recognized as valid.
The regular expression used in the battle_tag_check method is r"^[a-zA-Z0-9]{3,12}#[0-9]{4,5}$". This should be updated to r"^[a-zA-Z0-9]{3,12}#[0-9]{4,6}$" to accommodate battletags with 6-digit IDs.
The text was updated successfully, but these errors were encountered:
Describe the bug
The
battle_tag_check
method in theOverwatch
class incorrectly restricts the battletag ID to only 4 or 5 digits. Overwatch player IDs can sometimes be 6 digits long, so this validation fails for valid battletags with 6-digit IDs.To Reproduce
Steps to reproduce the behavior:
all_player_data
method with a battletag that has a 6-digit ID, e.g., ExampleUser#123456.Expected behavior
The method should correctly validate battletags with IDs that are 4, 5, or 6 digits long. Battletags such as ExampleUser#123456 should be recognized as valid.
The regular expression used in the
battle_tag_check
method isr"^[a-zA-Z0-9]{3,12}#[0-9]{4,5}$".
This should be updated tor"^[a-zA-Z0-9]{3,12}#[0-9]{4,6}$"
to accommodate battletags with 6-digit IDs.The text was updated successfully, but these errors were encountered: