Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratio division looks wrong #202

Open
etiago opened this issue Dec 16, 2022 · 0 comments
Open

Ratio division looks wrong #202

etiago opened this issue Dec 16, 2022 · 0 comments

Comments

@etiago
Copy link

etiago commented Dec 16, 2022

In the following line:

r operator/(r a, r b) { return {a.x * b.x, a.y * b.y}; }

Instead of:

r operator/(r a, r b) { return {a.x * b.x, a.y * b.y}; }

I think this is showing the division of two ratios and it should show:

r operator/(r a, r b) { return {a.x * b.y, a.y * b.x}; }

More generally, the division shows exactly the same as the multiplication which doesn't seem to make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant