From cc080a2308e102448cf1f120b80f46e614c9dbab Mon Sep 17 00:00:00 2001 From: chengmengli06 Date: Thu, 1 Feb 2024 10:34:56 +0800 Subject: [PATCH 1/3] fix not support metric error not raised bug --- easy_rec/python/model/match_model.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/easy_rec/python/model/match_model.py b/easy_rec/python/model/match_model.py index 94e840813..294bb3dd4 100644 --- a/easy_rec/python/model/match_model.py +++ b/easy_rec/python/model/match_model.py @@ -231,7 +231,7 @@ def _build_list_wise_metric_graph(self, eval_config): label, logits[:, :batch_size], metric.recall_at_topk.topk) else: - ValueError('invalid metric type: %s' % str(metric)) + raise ValueError('invalid metric type: %s' % str(metric)) return metric_dict def _build_point_wise_metric_graph(self, eval_config): @@ -248,7 +248,7 @@ def _build_point_wise_metric_graph(self, eval_config): metric_dict['mean_absolute_error'] = metrics_tf.mean_absolute_error( tf.to_float(label), self._prediction_dict['y']) else: - ValueError('invalid metric type: %s' % str(metric)) + raise ValueError('invalid metric type: %s' % str(metric)) return metric_dict def get_outputs(self): From fbf5b182a9e719fa2d58c68ae41be26596fa5478 Mon Sep 17 00:00:00 2001 From: chengmengli06 Date: Thu, 1 Feb 2024 15:28:23 +0800 Subject: [PATCH 2/3] fix not support metric error not raised bug --- .../dssm_neg_sampler_need_key_feature.config | 11 ++++++----- .../dssm_neg_sampler_sequence_feature.config | 11 ++++++----- 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/samples/model_config/dssm_neg_sampler_need_key_feature.config b/samples/model_config/dssm_neg_sampler_need_key_feature.config index 12a8621cc..f1b52031d 100644 --- a/samples/model_config/dssm_neg_sampler_need_key_feature.config +++ b/samples/model_config/dssm_neg_sampler_need_key_feature.config @@ -27,11 +27,12 @@ eval_config { auc { } } - metrics_set: { - gauc { - uid_field: "user_id" - } - } + # currently not supported + # metrics_set: { + # gauc { + # uid_field: "user_id" + # } + # } } data_config { diff --git a/samples/model_config/dssm_neg_sampler_sequence_feature.config b/samples/model_config/dssm_neg_sampler_sequence_feature.config index df6896408..6038b8952 100644 --- a/samples/model_config/dssm_neg_sampler_sequence_feature.config +++ b/samples/model_config/dssm_neg_sampler_sequence_feature.config @@ -27,11 +27,12 @@ eval_config { auc { } } - metrics_set: { - gauc { - uid_field: "user_id" - } - } + # currently not supported + # metrics_set: { + # gauc { + # uid_field: "user_id" + # } + # } } data_config { From 3ee1556d8603b13f72957fa14278f2f3fa614a2f Mon Sep 17 00:00:00 2001 From: chengmengli06 Date: Fri, 2 Feb 2024 14:47:22 +0800 Subject: [PATCH 3/3] update eval metric for dssm test cases --- samples/model_config/dssm_neg_sampler_need_key_feature.config | 3 +-- samples/model_config/dssm_neg_sampler_sequence_feature.config | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/samples/model_config/dssm_neg_sampler_need_key_feature.config b/samples/model_config/dssm_neg_sampler_need_key_feature.config index f1b52031d..ea7cc8342 100644 --- a/samples/model_config/dssm_neg_sampler_need_key_feature.config +++ b/samples/model_config/dssm_neg_sampler_need_key_feature.config @@ -24,8 +24,7 @@ train_config { eval_config { metrics_set: { - auc { - } + recall_at_topk { topk: 3 } } # currently not supported # metrics_set: { diff --git a/samples/model_config/dssm_neg_sampler_sequence_feature.config b/samples/model_config/dssm_neg_sampler_sequence_feature.config index 6038b8952..5ce0af37f 100644 --- a/samples/model_config/dssm_neg_sampler_sequence_feature.config +++ b/samples/model_config/dssm_neg_sampler_sequence_feature.config @@ -24,8 +24,7 @@ train_config { eval_config { metrics_set: { - auc { - } + recall_at_topk { topk: 3 } } # currently not supported # metrics_set: {