From a6f04fabc62e4285d557094a9f738cdc9cd5aaad Mon Sep 17 00:00:00 2001 From: "xiaolei.zl" Date: Mon, 28 Oct 2024 15:38:15 +0800 Subject: [PATCH] fixing Committed-by: xiaolei.zl from Dev container --- flex/engines/graph_db/database/wal.h | 18 ------------------ .../graphscope/gsctl/scripts/install_deps.sh | 6 +++--- 2 files changed, 3 insertions(+), 21 deletions(-) diff --git a/flex/engines/graph_db/database/wal.h b/flex/engines/graph_db/database/wal.h index 29ba548d3b55..4f86c91f4f3d 100644 --- a/flex/engines/graph_db/database/wal.h +++ b/flex/engines/graph_db/database/wal.h @@ -80,17 +80,6 @@ class IWalWriter { virtual void open(const std::string& path, int thread_id) = 0; virtual void close() = 0; virtual IWalWriter::WalWriterType type() const = 0; - /** - * @brief Append the data to the WAL. - * The published messages contains these info. - * 1. The thread id - * 2. The timestamp of the message(could be deemed as the id of WAL). - * 3. The data(The WAL content). - * - * @param data The data to be sent - * @param length The length of the data - * - */ virtual bool append(const char* data, size_t length) = 0; }; @@ -102,11 +91,8 @@ class LocalWalWriter : public IWalWriter { ~LocalWalWriter() { close(); } void open(const std::string& path, int thread_id) override; - void close() override; - bool append(const char* data, size_t length) override; - IWalWriter::WalWriterType type() const override; private: @@ -127,11 +113,8 @@ class KafkaWalWriter : public IWalWriter { ~KafkaWalWriter() { close(); } void open(const std::string& kafka_topic, int thread_id) override; - void close() override; - bool append(const char* data, size_t length) override; - IWalWriter::WalWriterType type() const override; private: @@ -229,7 +212,6 @@ class KafkaWalConsumer { std::string poll(); private: - bool running; std::vector> consumers_; std::priority_queue, CustomComparator> message_queue_; diff --git a/python/graphscope/gsctl/scripts/install_deps.sh b/python/graphscope/gsctl/scripts/install_deps.sh index 1de02edf06bb..29e32fae319f 100755 --- a/python/graphscope/gsctl/scripts/install_deps.sh +++ b/python/graphscope/gsctl/scripts/install_deps.sh @@ -853,9 +853,9 @@ install_analytical_java_dependencies() { fi } -INTERACTIVE_MACOS=("apache-arrow" "rapidjson" "boost" "glog" "gflags") -INTERACTIVE_UBUNTU=("rapidjson-dev" "libgoogle-glog-dev" "libgflags-dev") -INTERACTIVE_CENTOS=("rapidjson-devel") +INTERACTIVE_MACOS=("apache-arrow" "rapidjson" "boost" "glog" "gflags", "librdkafka") +INTERACTIVE_UBUNTU=("rapidjson-dev" "libgoogle-glog-dev" "libgflags-dev", "librdkafka-dev") +INTERACTIVE_CENTOS=("rapidjson-devel", "librdkafka-devel") install_interactive_dependencies() { # dependencies package