optimize lazy collectAll implement

[RainMark]

Search before asking

• I searched the issues and found no similar issues.

What happened + What you expected to happen

async_simple/async_simple/coro/Collect.h

Line 229 in ab70389

detail::CollectAnyAwaiter<LazyType<T>, IAlloc>>;

Lazy<> foo() {}

collectAll(foo().via(executor)) is equal to collectAllPara(foo())

maybe we can use collectAll(foo().via(executor)) to simplify the collectAllPara, for example: collectAllPara call collectAll(foo().via(executor)) directly

Reproduction way

Anything else

Are you willing to submit a PR?

• Yes I am willing to submit a PR!

[ChuanqiXu9]

What if the lazy don't contain an Executor when we call collectAllPara(foo())?

[RainMark]

What if the lazy don't contain an Executor when we call collectAllPara(foo())?

collectAllPara can not run sub coroutines in parallel without executor

[ChuanqiXu9]

Another problem is that collectAllPara is not equal to collectAll, it might be design mistake. We may need to change it.

[RainMark]

Another problem is that collectAllPara is not equal to collectAll, it might be design mistake. We may need to change it.

em，we can remove

using AT = std::conditional_t<
        std::is_same_v<LazyType<T>, Lazy<T>>,
        detail::SimpleCollectAllAwaitable<T, IAlloc, OAlloc, Para>,
        detail::CollectAllAwaiter<LazyType<T>, IAlloc, OAlloc, Para>>;

[ChuanqiXu9]

Another problem is that collectAllPara is not equal to collectAll, it might be design mistake. We may need to change it.

em，we can remove

using AT = std::conditional_t<
        std::is_same_v<LazyType<T>, Lazy<T>>,
        detail::SimpleCollectAllAwaitable<T, IAlloc, OAlloc, Para>,
        detail::CollectAllAwaiter<LazyType<T>, IAlloc, OAlloc, Para>>;

Maybe we need to do more work on the interface. The previous design looks not good.