Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Address validation token is too easy. #266

Open
Luffbee opened this issue Nov 14, 2022 · 1 comment · May be fixed by #417
Open

[Bug]: Address validation token is too easy. #266

Luffbee opened this issue Nov 14, 2022 · 1 comment · May be fixed by #417

Comments

@Luffbee
Copy link

Luffbee commented Nov 14, 2022

What happened?

8.1.4. Address Validation Token Integrity
An address validation token MUST be difficult to guess. Including a random value with at least 128 bits of entropy in the token would be sufficient, but this depends on the server remembering the value it sends to clients.

Xquic use ip address + expire time as token.

Steps To Reproduce

Read the code.

Relevant log output

No response
@Luffbee Luffbee changed the title [Bug]: Address validation token is too easy to guess. [Bug]: Address validation token is too easy. Nov 14, 2022
@Ya-Pasha-364shy
Copy link
Contributor

Hello, i'm working on it

Ya-Pasha-364shy added a commit to Ya-Pasha-364shy/xquic that referenced this issue May 5, 2024
@Ya-Pasha-364shy
[~] added token complexity for client-server interaction
cb941c2 
Fixes alibaba#266 issue
@Ya-Pasha-364shy Ya-Pasha-364shy linked a pull request May 5, 2024 that will close this issue
Open
Ya-Pasha-364shy added a commit to Ya-Pasha-364shy/xquic that referenced this issue May 13, 2024
@Ya-Pasha-364shy
[~] added token complexity for client-server interaction
2747e9d 
Fixes alibaba#266 issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[~] added token complexity for client-server interaction Ya-Pasha-364shy/xquic
2 participants
@Luffbee @Ya-Pasha-364shy