Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/alicloud_cs_edge_kubernetes: deprecated kubeconfig attribute; resource/alicloud_cs_managed_kubernetes: deprecated kubeconfig attribute; resource/alicloud_cs_kubernetes: deprecated kubeconfig attribute; resource/alicloud_cs_serverless_kubernetes: deprecated kubeconfig attribute; docs: deprecated kubeconfig attribute #8333

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lijiuxing1
Copy link
Contributor

@lijiuxing1 lijiuxing1 commented Feb 12, 2025

No description provided.

@lijiuxing1 lijiuxing1 force-pushed the deprecated_certificate_authority branch 3 times, most recently from d676a68 to 2d9ecf1 Compare February 13, 2025 05:10
@lijiuxing1 lijiuxing1 changed the title resource/alicloud_cs_edge_kubernetes: deprecated kubeconfig attribute… resource/alicloud_cs_edge_kubernetes: deprecated kubeconfig attribute; resource/alicloud_cs_managed_kubernetes: deprecated kubeconfig attribute; resource/alicloud_cs_kubernetes: deprecated kubeconfig attribute; resource/alicloud_cs_serverless_kubernetes: deprecated kubeconfig attribute; docs: deprecated kubeconfig attribute Feb 13, 2025
},
"client_cert": {
Type: schema.TypeString,
Optional: true,
Deprecated: "Field 'client_cert' has been deprecated from provider version 1.225.0. From version 1.187.0+, new DataSource 'alicloud_cs_cluster_credential' is recommended to manage cluster's kubeconfig, you can also save the 'certificate_authority.client_cert' attribute content of new DataSource 'alicloud_cs_cluster_credential' to an appropriate path(like ~/.kube/client-cert.pem) for replace it.",
Copy link
Collaborator

@MrWolong MrWolong Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client_cert, client_key, cluster_ca_cert从资源接入的时候就不支持传值,所以废弃版本应该是1.243.0,certificate_authority也一样。统一修改为以下的形式,
Field ' ' has been deprecated from provider version 1.243.0. From version 1.243.0, XXXXXX

@@ -543,19 +543,22 @@ func resourceAlicloudCSKubernetes() *schema.Resource {
"kube_config": {
Type: schema.TypeString,
Optional: true,
Removed: "Field 'kube_config' has been removed from provider version 1.212.0. New DataSource 'alicloud_cs_cluster_credential' manage your cluster's kube config.",
Removed: "Field 'kube_config' has been removed from provider version 1.212.0. Please use the attribute 'output_file' of new DataSource 'alicloud_cs_cluster_credential' to replace it",
},
"client_cert": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client_cert, client_key, cluster_ca_cert, certificate_authority
Field ' ' has been deprecated from provider version 1.243.0. From version 1.243.0, XXXXXX

@@ -478,19 +478,22 @@ func resourceAlicloudCSManagedKubernetes() *schema.Resource {
"kube_config": {
Type: schema.TypeString,
Optional: true,
Removed: "Field 'kube_config' has been removed from provider version 1.212.0. New DataSource 'alicloud_cs_cluster_credential' manage your cluster's kube config.",
Removed: "Field 'kube_config' has been removed from provider version 1.212.0. Please use the attribute 'output_file' of new DataSource 'alicloud_cs_cluster_credential' to replace it",
},
"client_cert": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client_cert, client_key, cluster_ca_cert, certificate_authority
Field ' ' has been deprecated from provider version 1.243.0. From version 1.243.0, XXXXXX

@@ -116,19 +116,22 @@ func resourceAlicloudCSServerlessKubernetes() *schema.Resource {
"kube_config": {
Type: schema.TypeString,
Optional: true,
Deprecated: "Field 'kube_config' has been deprecated from provider version 1.187.0. New DataSource 'alicloud_cs_cluster_credential' manage your cluster's kube config.",
Deprecated: "Field 'kube_config' has been deprecated from provider version 1.187.0. Please use the attribute 'output_file' of new DataSource 'alicloud_cs_cluster_credential' to replace it.",
},
"client_cert": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client_cert, client_key, cluster_ca_cert
Field ' ' has been deprecated from provider version 1.243.0. From version 1.243.0, XXXXXX

@lijiuxing1 lijiuxing1 force-pushed the deprecated_certificate_authority branch 3 times, most recently from bc5b714 to 6216a8c Compare February 13, 2025 11:16
@@ -275,19 +275,22 @@ func resourceAlicloudCSEdgeKubernetes() *schema.Resource {
"kube_config": {
Type: schema.TypeString,
Optional: true,
Deprecated: "Field 'kube_config' has been deprecated from provider version 1.187.0. New DataSource 'alicloud_cs_cluster_credential' manage your cluster's kube config.",
Deprecated: "Field 'kube_config' has been deprecated from provider version 1.243.0. Please use the attribute 'output_file' of new DataSource 'alicloud_cs_cluster_credential' to replace it.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube_config改回原来的1.187.0版本

@@ -543,19 +543,22 @@ func resourceAlicloudCSKubernetes() *schema.Resource {
"kube_config": {
Type: schema.TypeString,
Optional: true,
Removed: "Field 'kube_config' has been removed from provider version 1.212.0. New DataSource 'alicloud_cs_cluster_credential' manage your cluster's kube config.",
Removed: "Field 'kube_config' has been removed from provider version 1.243.0. Please use the attribute 'output_file' of new DataSource 'alicloud_cs_cluster_credential' to replace it",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube_config改回原来的1.212.0版本

@@ -478,19 +478,22 @@ func resourceAlicloudCSManagedKubernetes() *schema.Resource {
"kube_config": {
Type: schema.TypeString,
Optional: true,
Removed: "Field 'kube_config' has been removed from provider version 1.212.0. New DataSource 'alicloud_cs_cluster_credential' manage your cluster's kube config.",
Removed: "Field 'kube_config' has been removed from provider version 1.243.0. Please use the attribute 'output_file' of new DataSource 'alicloud_cs_cluster_credential' to replace it",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube_config改回原来的1.212.0版本

@@ -116,19 +116,22 @@ func resourceAlicloudCSServerlessKubernetes() *schema.Resource {
"kube_config": {
Type: schema.TypeString,
Optional: true,
Deprecated: "Field 'kube_config' has been deprecated from provider version 1.187.0. New DataSource 'alicloud_cs_cluster_credential' manage your cluster's kube config.",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kube_config改回原来的1.187.0版本

@lijiuxing1 lijiuxing1 force-pushed the deprecated_certificate_authority branch 2 times, most recently from a5f7219 to a61f84d Compare February 14, 2025 06:16
…; resource/alicloud_cs_managed_kubernetes: deprecated kubeconfig attribute; resource/alicloud_cs_kubernetes: deprecated kubeconfig attribute; resource/alicloud_cs_serverless_kubernetes: deprecated kubeconfig attribute; docs: deprecated kubeconfig attribute
Copy link
Collaborator

@MrWolong MrWolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Collaborator

@MrWolong MrWolong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Copy link
Collaborator

@ChenHanZhang ChenHanZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants