You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current testing infrastructure is lacking. We have many similar functions: dotenv, from_filename, from_path, from_read and their override and iter variants; but only the dotenv function is being tested for expected behaviour (multiline comments, BOM ignoring etc). I believe having these tests on each function is important to avoid future regressions and ensure the stability of the crate.
We could simply add these tests for each function but it would create an unmaintainable mess of the tests folder. Currently, each test must be in its own file (process) to avoid variable collisions (as the tested functions alter the process environment). Moreover, the output from cargo test will get even more unwieldy that it currently is.
Create a collection of abstracted checks to run against each public function and their variants.
The second part is a bit harder: we want it to be easy to add more checks AND easy to add the checks to a new public function. They should also be easy to change.
The text was updated successfully, but these errors were encountered:
The current testing infrastructure is lacking. We have many similar functions:
dotenv
,from_filename
,from_path
,from_read
and theiroverride
anditer
variants; but only thedotenv
function is being tested for expected behaviour (multiline comments, BOM ignoring etc). I believe having these tests on each function is important to avoid future regressions and ensure the stability of the crate.We could simply add these tests for each function but it would create an unmaintainable mess of the
tests
folder. Currently, each test must be in its own file (process) to avoid variable collisions (as the tested functions alter the process environment). Moreover, the output fromcargo test
will get even more unwieldy that it currently is.I prepose a 2-part solution:
The second part is a bit harder: we want it to be easy to add more checks AND easy to add the checks to a new public function. They should also be easy to change.
The text was updated successfully, but these errors were encountered: