-
Notifications
You must be signed in to change notification settings - Fork 14
Enforce pr title conventions #105
Comments
Actually not just the PR name this is a conventional commit message. I want to promote a project by @TomerFi, to which I am also one of the contributors. I think this is a great tool that does exactly what we need here. |
I can do this task if you want |
@dolby360 I think we can can either add a flag inside the conventional-commits-handler to include PR titles: ---
pr:
conventionalCommits:
includePrTitle: true
rules:
'body-max-line-length': [2, 'always', 150] or add a designated handler: ---
pr:
conventionalPrTitles:
conventionalCommits:
rules:
'body-max-line-length': [2, 'always', 150] I'm not sure what's better... |
@TomerFi I'll open a new issue in the repository and we will decide about the design. |
We use squash strategy when pushing feature branches into main so the structure of the commit messages is not that important to us since it is being overridden. @dolby360 still want to take this issue? @TomerFi if your project solves that problem for us, we can definitely integrate it into our project :) |
I'll add the handler for conventional pr titles to auto-me-bot. |
No problems @dimabru assign me for this issue |
@dolby360 new handler released in auto-me-bot 1.4.0. |
Is your feature request related to a problem? Please describe.
PR titles should align to the same standards
Describe the solution you'd like
A Github workflow that runs on every PR that enforces commit message conventions as described here
For example:
build: support docker push
refactor: improve unit tests
feat: create json output flag
workflow should do the following:
The text was updated successfully, but these errors were encountered: