recycling fails if probe core is not final part

[rachelf42]

when i attempt to use the recycler, if the probe core is not the very last part to be recycled, it fails when it gets to the probe core, leaving a half-recycled ship floating there
i think it could be related to #63?

to replicate, simply launch and dock an unmanned craft where the probe core is not the root part (i used a slightly modified Raptor9 T4H, with some Dockable DIY Kits, where the root part was the top fuel tank) to the Orbital Workshop, then undock it from its payload, and attempt to recycle it. By watching the expanded recycler part tree, you can see that it fails and stops recycling once the probe core is near the bottom of the list

modlist, in case it helps: https://pastebin.com/9vaZ9vk3

recycle tree at start, and the vessel i tried:

recycle tree and vessel, once it stopped:

[allista]

So far was unable to reproduce, though something is definitely not right in the UI, as indicated by the NRE visible at the end.

https://gfycat.com/bronzefrenchbuzzard

[allista]

Fixed a UI bug that caused part nodes to remain in Recycler window after part's destruction. But I doubt it's what caused the behaviour you described.

[rachelf42]

if there's anything i can do to help you diagnose, just let me know!

[allista]

First of all, let's try to look at the logs: recycling that had stopped without notice may have thrown some exceptions. Note, you'll have to start the game, replicate the bug, then get the Player.log file that Unity generated.

Second, I will need the .craft file of the vessel that couldn't be recycled. And if you're using ckan, I would prefer mod list exported from there to just import it on my side, rather than hunting for each mod individually.

[rachelf42]

this was on a career save, so next time i'm playing i'll see if i can replicate it on a sandbox save so i can help but not waste resources

[rachelf42]

okay, so after using Ship Save Splicer to copy the station, and manually copying the .craft file, i was able to replicate it, here's the log and the craft file
also, is this the right file from ckan this time? i had to change it from ".ckan" to ".ckan.txt" so github would let me upload it

steps i took to replicate:

1. launch the "Thunder 4 Heavy - Bugged"
2. use MJ Ascent Guidance to get to a 250km orbit (default settings except auto-deploy solar is off)
3. set MJ autostage in Utilities if still on stage 2 (likely)
4. use MJ Rendezvous Autopilot to get to the Orbital Workshop (~500km orbit in my case)
5. decouple stage 2 if still there, then activate MJ Docking Autopilot
6. decouple the bottom NRAP docking port (using NRAP to simulate a DIY kit)
7. switch to Orbital Workshop and recycle
8. observe bugged behaviour

FILES
modpack.ckan.txt
Player.log
Thunder 4 Heavy - Bugged.craft.txt