From 55e1db6d03b45cde0d145c838e911c132f7b77ea Mon Sep 17 00:00:00 2001 From: 0xKurt Date: Thu, 12 Dec 2024 15:54:09 +0100 Subject: [PATCH 1/2] update isPoolManager --- contracts/core/Allo.sol | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/contracts/core/Allo.sol b/contracts/core/Allo.sol index 5f0a42bc6..73d96a3a8 100644 --- a/contracts/core/Allo.sol +++ b/contracts/core/Allo.sol @@ -582,7 +582,8 @@ contract Allo is /// @param _address The address to check /// @return This will return 'true' if the address is a pool manager, otherwise 'false' function _isPoolManager(uint256 _poolId, address _address) internal view returns (bool) { - return hasRole(pools[_poolId].managerRole, _address) || _isPoolAdmin(_poolId, _address); + return hasRole(pools[_poolId].managerRole, _address) || _isPoolAdmin(_poolId, _address) + || registry.isOwnerOrMemberOfProfile(pools[_poolId].profileId, msg.sender); } /// @notice Updates the registry address From 9e18dd03e9b4c651e2f82306acb398fdd26f5515 Mon Sep 17 00:00:00 2001 From: 0xKurt Date: Thu, 12 Dec 2024 15:57:24 +0100 Subject: [PATCH 2/2] rm sender --- contracts/core/Allo.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/core/Allo.sol b/contracts/core/Allo.sol index 73d96a3a8..c11e66014 100644 --- a/contracts/core/Allo.sol +++ b/contracts/core/Allo.sol @@ -583,7 +583,7 @@ contract Allo is /// @return This will return 'true' if the address is a pool manager, otherwise 'false' function _isPoolManager(uint256 _poolId, address _address) internal view returns (bool) { return hasRole(pools[_poolId].managerRole, _address) || _isPoolAdmin(_poolId, _address) - || registry.isOwnerOrMemberOfProfile(pools[_poolId].profileId, msg.sender); + || registry.isOwnerOrMemberOfProfile(pools[_poolId].profileId, _address); } /// @notice Updates the registry address