diff --git a/src/bashi/filter_software_dependency.py b/src/bashi/filter_software_dependency.py index 3867317..d26ab1c 100644 --- a/src/bashi/filter_software_dependency.py +++ b/src/bashi/filter_software_dependency.py @@ -104,7 +104,6 @@ def software_dependency_filter( f"{row[CMAKE].version}", ) return False - # Rule: d3 # all ROCm images are Ubuntu 20.04 based or newer # related to rule c19 @@ -118,7 +117,6 @@ def software_dependency_filter( "older than 20.04", ) return False - # Rule: d4 # Ubuntu 20.04 and newer is not available with CUDA older than 10.2 """ diff --git a/src/bashi/results.py b/src/bashi/results.py index a2d7738..c4a7e3e 100644 --- a/src/bashi/results.py +++ b/src/bashi/results.py @@ -85,6 +85,7 @@ def get_expected_bashi_parameter_value_pairs( param_val_pair_list, removed_param_val_pair_list ) _remove_unsupported_cuda_versions_for_ubuntu(param_val_pair_list, removed_param_val_pair_list) + return (param_val_pair_list, removed_param_val_pair_list) @@ -829,7 +830,6 @@ def _remove_all_rocm_images_older_than_ubuntu2004_based( value_version2=ANY_VERSION, ) - def _remove_unsupported_cuda_versions_for_ubuntu( parameter_value_pairs: List[ParameterValuePair], removed_parameter_value_pairs: List[ParameterValuePair], diff --git a/tests/test_filter_software_dependency.py b/tests/test_filter_software_dependency.py index 3cf098c..f7570c5 100644 --- a/tests/test_filter_software_dependency.py +++ b/tests/test_filter_software_dependency.py @@ -424,3 +424,4 @@ def test_not_valid_cuda_versions_for_ubuntu_d3(self): reason_msg.getvalue(), f"CUDA {CUDA_version} is not available in Ubuntu 22.04", ) + diff --git a/tests/test_results.py b/tests/test_results.py index 58b3f68..57a79d9 100644 --- a/tests/test_results.py +++ b/tests/test_results.py @@ -2493,7 +2493,7 @@ def test_remove_all_rocm_images_older_than_ubuntu2004_based(self): expected_results, create_diff_parameter_value_pairs(test_param_value_pairs, expected_results), ) - + def test_remove_unsupported_cuda_versions_for_ubuntu(self): test_param_value_pairs: List[ParameterValuePair] = parse_expected_val_pairs( [