Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Manual#destroy deletes all relevant SectionEditions #1116

Open
chrisroos opened this issue May 18, 2017 · 1 comment
Open

Ensure Manual#destroy deletes all relevant SectionEditions #1116

chrisroos opened this issue May 18, 2017 · 1 comment

Comments

@chrisroos
Copy link
Contributor

The Manual#destroy method iterates over a manual's sections and destroys each of the section's editions. It does this by calling #destroy on each of the editions returned from Section#editions.
Because Section#editions simply returns the editions that were supplied when the Section was created we can't currently guarantee that we'd be destroying all editions.
chrisroos added a commit that referenced this issue May 25, 2017
@chrisroos
Make Section#editions private
1e1346e 
I'm working toward removing the Section#editions method completely and
making it private ensures that nothing other than `Section` is using it.

Note that I've had to change the `Manual#destroy` method so that it's
calling `Section#all_editions` instead of `#editions`. This fixes issue
 #1116.
@chrisroos
Copy link
Contributor Author

The changes in PR #1155 should fix this issue.

chrisroos added a commit that referenced this issue May 25, 2017
@chrisroos
Make Section#editions private
f917ac4 
I'm working toward removing the Section#editions method completely and
making it private ensures that nothing other than `Section` is using it.

Note that I've had to change the `Manual#destroy` method so that it's
calling `Section#all_editions` instead of `#editions`. This fixes issue
 #1116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chrisroos