From 74d5d12326d22d6210dcdcc617601a40b5c9c80c Mon Sep 17 00:00:00 2001 From: Graham Lewis <44037625+gclssvglx@users.noreply.github.com> Date: Fri, 7 Jun 2024 15:50:19 +0100 Subject: [PATCH 1/2] Add independent-inquiry.uk to the allowlist --- app/validators/gov_uk_url_format_validator.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/app/validators/gov_uk_url_format_validator.rb b/app/validators/gov_uk_url_format_validator.rb index 323606cd1b9..dc54659c550 100644 --- a/app/validators/gov_uk_url_format_validator.rb +++ b/app/validators/gov_uk_url_format_validator.rb @@ -3,6 +3,7 @@ class GovUkUrlFormatValidator < ActiveModel::EachValidator EXTERNAL_HOST_ALLOW_LIST = %w[ .caa.co.uk .gov.uk + .independent-inquiry.uk .judiciary.uk .nationalhighways.co.uk .nhs.uk From 5289b476b73e9576907c29eb5c58fa4cdbdce3db Mon Sep 17 00:00:00 2001 From: Graham Lewis <44037625+gclssvglx@users.noreply.github.com> Date: Fri, 7 Jun 2024 15:50:40 +0100 Subject: [PATCH 2/2] Add test for allowlist with independent-inquiry.uk --- test/unit/app/models/unpublishing_test.rb | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/unit/app/models/unpublishing_test.rb b/test/unit/app/models/unpublishing_test.rb index c2179190b09..69a260ad593 100644 --- a/test/unit/app/models/unpublishing_test.rb +++ b/test/unit/app/models/unpublishing_test.rb @@ -66,6 +66,9 @@ class UnpublishingTest < ActiveSupport::TestCase unpublishing = build(:unpublishing, redirect: true, alternative_url: "#{Whitehall.public_protocol}://#{Whitehall.public_host}/example") assert unpublishing.valid? + unpublishing = build(:unpublishing, redirect: true, alternative_url: "https://www.independent-inquiry.uk/about-the-independent-inquiry/") + assert unpublishing.valid? + unpublishing = build(:unpublishing, redirect: true, alternative_url: "https://www.judiciary.uk/about-the-judiciary/") assert unpublishing.valid?