Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pages need access controls #79

Open
dylanmcreynolds opened this issue Mar 28, 2021 · 0 comments
Open

Pages need access controls #79

dylanmcreynolds opened this issue Mar 28, 2021 · 0 comments
Assignees

Comments

@dylanmcreynolds
Copy link
Collaborator

Currently the only object in Splash that enforces access controls are runs.

Runs will look a little different from pages as far as access controls go, as we have a little more control over things. But they will be similar. Here's generally the design:

View Access

  • splash-md documents will contain a new field called accessGroups. This will be a list of strings.
  • View access for listing pages will add a check to the mongo query to limit the results to only those items for which the user belongs to a team that is in the item's accessGroup field. (Similar to
    for team in user_teams:
    )
  • View access for an individual page access will be controlled in a similar way to
    run_auth = run.metadata['start'].get('data_groups')
    . I think we want a new TeamAccessPolicy class (similar to the TeamRunChecker) to assert policy specific to pages...I like the work Policy better than AccessChecker.

View Edit

  • The policy, for now, for Pages will be "anyone with access can edit". But I want this to be controled by the TeamAccessPolicy (above) so that it's easy and obvious to change the policy if we need to.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants