Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basemeans in simulate_experiment when num_rep == 1 #62

Open
orangebromeliad opened this issue Mar 22, 2019 · 2 comments
Open

basemeans in simulate_experiment when num_rep == 1 #62

orangebromeliad opened this issue Mar 22, 2019 · 2 comments

Comments

@orangebromeliad
Copy link

Hi,

I only wanted to generate one simulated replicate however I was encountering issues with this because it would return the error: 'Object basemeans not found'. I notice that in the simulate_experiment code that I have (I downloaded polyester a couple of days ago from Bioconductor) if num_reps == 1 then basemeans is never defined, however the code on GitHub has fixed this bug (I think). Is polyester still awaiting updates on bioconductor?

Best wishes,
Tim.

Code from my version of polyester v.3.8:
line 47

if (length(num_reps) == 1) {
    fold_changes = matrix(rep(1, length(transcripts)))
  }

Github code:
line 368

if(length(num_reps) == 1){
        fold_changes = matrix(rep(1, length(transcripts)))
        basemeans = reads_per_transcript * fold_changes
    } else if(length(num_reps) == 2) {
@JMF47
Copy link
Collaborator

JMF47 commented Mar 22, 2019

Hi Tim. Let me look into this. It’s likely a case of updates not being pushed on my end successfully to the bioconductor build. Thanks!

@alorchhota
Copy link

I am having an issue to simulate RNA-seq from a single group using simulate_experiment(). I believe my issue is similar to this one, so I'm posting it here.

As this is about a single group, I thought I could avoid passing any value for fold_changes. But it resulted in the following error.



Error in is.numeric(fold_changes) :
argument "fold_changes" is missing, with no default



Next I tried passing fold_changes = NULL which produced the following error.

Error in .check_fold_changes(fold_changes, num_reps, transcripts) :
is.numeric(fold_changes) is not TRUE

Then I tried passing fold_changes = 1 which resulted in the following error. Setting fold_changes = matrix(1, nrow = n_transcripts, ncol = 1) also generates the same error. This part is, I believe, related to the issue mentioned by Tim.

Error in simulate_experiment(gtf = tx_gtf_fn, seqpath = dna_dir, outdir = out_dir, :
object 'basemeans' not found

FYI: I'm using polyester_1.18.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants