Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for GFF3 #76

Open
TBooker opened this issue Aug 27, 2021 · 1 comment
Open

Support for GFF3 #76

TBooker opened this issue Aug 27, 2021 · 1 comment

Comments

@TBooker
Copy link

TBooker commented Aug 27, 2021

Thanks for developing such a useful piece of software!

I bumped into an issue when using GFF3 files in Polyester. In GFF3, attributes are separated by and equals signs ("=") rather than spaces (" "), so the program was throwing errors when it reached line 27 in getAttributeField.R:
a = strsplit(atts, split = " ", fixed = TRUE)
I just did a quick substitution in my GFF to get around it and it worked fine, but it would be good to have an argument to specify this. E.g.

a = strsplit(atts, split = attr_field_separator, fixed = TRUE)
and have attr_field_separator inherited from the top level function simulate_experiment.

I would submit a pull request, but I'm heading off on parental leave today so won't have the time for a 7 weeks.

@alyssafrazee
Copy link
Owner

Thanks for the suggestion! Agree that would be a good idea. Feel free to submit a PR whenever you're ready -- chances are low that I personally will get to this within the next 2 months, though I may get to it eventually!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants