You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently PyProgs installs as waveloc and examples as waveloc_examples. See also the setup.py script (https://github.com/amaggi/waveloc/blob/master/setup.py#L12). This is probably unnecessarily confusing. So I'd propose just to rename these directories in the repo.
Also installing the examples as module does not really make sense, these are all callable scripts which should not be imported as modules.
Probably, deprecated and README could be moved from PyProgs.
I am wondering if the tests (currently in PyProgs) should not be put into a separate directory.
Here are some proposals for cleanup:
PyProgs
installs aswaveloc
andexamples
aswaveloc_examples
. See also thesetup.py
script (https://github.com/amaggi/waveloc/blob/master/setup.py#L12). This is probably unnecessarily confusing. So I'd propose just to rename these directories in the repo.examples
as module does not really make sense, these are all callable scripts which should not be imported as modules.deprecated
andREADME
could be moved from PyProgs.PyProgs
) should not be put into a separate directory.run_*
scripts inscripts
? Should they be considered examples?lib
,nll
,test_data
are probably related to tests or examples as wellThese are just some observation. So feel free to just ignore them.
The text was updated successfully, but these errors were encountered: