Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EExpArgGroup should tag child values with the corresponding parameter #896

Open
zslayton opened this issue Jan 10, 2025 · 1 comment
Open
Labels
bug Something isn't working

Comments

@zslayton
Copy link
Contributor

When a macro emits an argument value that was originally passed in as part of an argument group, the value isn't tagged with the group's corresponding parameter.

image

We should only show the encoding of 1 2 3 inside the e-expression argument group, but we show their encoding again when they're emitted by values because they aren't tagged with x.

@zslayton zslayton added the bug Something isn't working label Jan 10, 2025
@zslayton
Copy link
Contributor Author

On closer inspection, I believe that the problem may be that (:: ...) is tagging its child expressions with x, but then (:values ...) is setting their variable back to None because (:values ...) itself doesn't have a variable.

It should be possible for tags to be overwritten with a new variable, but not unset altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant