Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Showvolume Audio Channel Names #839

Open
bturkus opened this issue Oct 17, 2024 · 8 comments
Open

Display Showvolume Audio Channel Names #839

bturkus opened this issue Oct 17, 2024 · 8 comments

Comments

@bturkus
Copy link
Collaborator

bturkus commented Oct 17, 2024

Hi,
I was wondering if people would be open to tweaking the showvolume filter in "Audio + Video" passthrough mode to display the audio channel names. We could do this in a few other places as well, but I think passthrough in A+V mode would be the most beneficial, as novice vrecord users would not necessarily know that CH1 is stacked on top of CH2 (this just occurred in a Video Preservation class--I knew we were wired improperly, but no one else picked up on it).

@privatezero as I believe you implemented this, what do you think?

Thanks,
Ben

@privatezero
Copy link
Member

Hi @bturkus we can definitely do this as channel names are already part of that filter - I think we turned them off because the levels tend to be low enough on all these old recordings that the channel names kind of interfere with the bars at the far left end of the meter.

The meters are set to linear right now, but we could change them to logarithmic and maybe that would be more useful? It would make the channel names way easier to read at least. (Example below in log mode with channel names on). Anyone have thoughts about going to logarithmic audio meters?
image

@privatezero
Copy link
Member

I made a quick branch you can try out to see what you think: https://github.com/amiaopensource/vrecord/tree/logmeters

@bturkus
Copy link
Collaborator Author

bturkus commented Oct 18, 2024

thanks @privatezero I'm sure this is great, but I'll test on Monday to confirm. Unrelated, but looking over active branches, do you need someone to test changes you made to mono audio configurations (audio-monitoring-tweaks)?

@privatezero
Copy link
Member

@bturkus oh yeah testing on that branch would be great! Can't remember why I didn't do a PR for that yet, I probably just got distracted with work. I think the main thing I was thinking about was the best way to handle the monitoring when a user selects the option to split two input channels into two separate mono tracks (since in our preview window you can't switch between two different audio tracks on the fly). Right now it just lets the user monitor them in stereo basically, which I think might be the best option but would be happy for any other thoughts about that!

@richardpl
Copy link

If you do not like transparency of default showvolume, you can add ,format=rgb0 after showvolume filter to force always black.
This will make names more visible, other alternatives is rescaling showvolume filter output with xbr/epx/hqx or similar filter.

@privatezero
Copy link
Member

@richardpl thanks for those! For myself, I kind of like the transparency on top of the video signal, but I'm curious what others think.

@bturkus
Copy link
Collaborator Author

bturkus commented Oct 21, 2024

yes, thanks @richardpl, we'll investigate this and keep the discussion going.

@privatezero I tested the log bars with names, and they seem good. thanks for doing this!

@libbyhopfauf
Copy link
Member

I tested this as well and like how this looks much better!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants