New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all nodes case classes or have companion object constructor #124

Open

tomerk opened this issue May 18, 2015 · 1 comment

Labels

admin

Contributor

tomerk commented May 18, 2015

Discussion with @etrain suggests that we should be very consistent about how nodes are constructed.

Because:

@etrain doesn't like new
including empty parens in some cases (case classes w/ default parameters) and not others (objects) is inconsistent

The plan is to have all nodes either be case classes, or have a companion object constructor

The text was updated successfully, but these errors were encountered:

Contributor

etrain commented May 18, 2015

To be fair - I have no problem with new - it's just a dislike for boilerplate.

Guidelines about where and when to use objects vs. case classes could also go in a style guide. #113

etrain added the admin label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment