From 8fbf2a20a2346aad38f04679f616e93aa54fdbc1 Mon Sep 17 00:00:00 2001 From: mattkram Date: Mon, 21 Oct 2024 21:48:32 -0500 Subject: [PATCH 1/4] Add test for parse_specs to attempt to reproduce --- tests/utils/test_parse_specs.py | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 tests/utils/test_parse_specs.py diff --git a/tests/utils/test_parse_specs.py b/tests/utils/test_parse_specs.py new file mode 100644 index 00000000..2ce2781c --- /dev/null +++ b/tests/utils/test_parse_specs.py @@ -0,0 +1,8 @@ +import binstar_client.utils.spec +def test_parse_specs(): + spec = binstar_client.utils.spec.parse_specs("bkreider/foo/1.2.3/blah-1.2.3.tar.bz2?x=1") + assert spec.user == "bkreider" + assert spec.name == "foo" + assert spec.version == "1.2.3" + assert spec.basename == "blah-1.2.3.tar.bz2" + assert spec.attrs == {"x": "1"} From 910273cdf4bf8daa8b6770655397f62635890936 Mon Sep 17 00:00:00 2001 From: mattkram Date: Mon, 21 Oct 2024 21:52:53 -0500 Subject: [PATCH 2/4] chore: lint --- tests/utils/test_parse_specs.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/utils/test_parse_specs.py b/tests/utils/test_parse_specs.py index 2ce2781c..7bab9ad3 100644 --- a/tests/utils/test_parse_specs.py +++ b/tests/utils/test_parse_specs.py @@ -1,4 +1,7 @@ +# pylint: disable=missing-module-docstring,missing-function-docstring import binstar_client.utils.spec + + def test_parse_specs(): spec = binstar_client.utils.spec.parse_specs("bkreider/foo/1.2.3/blah-1.2.3.tar.bz2?x=1") assert spec.user == "bkreider" From fc7c48803db7035d4f2a98c7911a133f7d6c1600 Mon Sep 17 00:00:00 2001 From: mattkram Date: Mon, 21 Oct 2024 22:04:03 -0500 Subject: [PATCH 3/4] Rename file and add a comment --- tests/utils/{test_parse_specs.py => test_spec.py} | 1 + 1 file changed, 1 insertion(+) rename tests/utils/{test_parse_specs.py => test_spec.py} (84%) diff --git a/tests/utils/test_parse_specs.py b/tests/utils/test_spec.py similarity index 84% rename from tests/utils/test_parse_specs.py rename to tests/utils/test_spec.py index 7bab9ad3..d53a21a2 100644 --- a/tests/utils/test_parse_specs.py +++ b/tests/utils/test_spec.py @@ -3,6 +3,7 @@ def test_parse_specs(): + # Reproducing for https://github.com/anaconda/anaconda-client/issues/642 spec = binstar_client.utils.spec.parse_specs("bkreider/foo/1.2.3/blah-1.2.3.tar.bz2?x=1") assert spec.user == "bkreider" assert spec.name == "foo" From b8adae22cec88196f1d494fb392608d3950e0440 Mon Sep 17 00:00:00 2001 From: mattkram Date: Mon, 21 Oct 2024 22:05:51 -0500 Subject: [PATCH 4/4] Change username --- tests/utils/test_spec.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/utils/test_spec.py b/tests/utils/test_spec.py index d53a21a2..69f4068d 100644 --- a/tests/utils/test_spec.py +++ b/tests/utils/test_spec.py @@ -4,8 +4,8 @@ def test_parse_specs(): # Reproducing for https://github.com/anaconda/anaconda-client/issues/642 - spec = binstar_client.utils.spec.parse_specs("bkreider/foo/1.2.3/blah-1.2.3.tar.bz2?x=1") - assert spec.user == "bkreider" + spec = binstar_client.utils.spec.parse_specs("someuser/foo/1.2.3/blah-1.2.3.tar.bz2?x=1") + assert spec.user == "someuser" assert spec.name == "foo" assert spec.version == "1.2.3" assert spec.basename == "blah-1.2.3.tar.bz2"