Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying scan and copy performance options cause exceptions #4

Closed
dabadab opened this issue Mar 7, 2023 · 1 comment
Closed

Specifying scan and copy performance options cause exceptions #4

dabadab opened this issue Mar 7, 2023 · 1 comment

Comments

@dabadab
Copy link

dabadab commented Mar 7, 2023

version: b803e3e commit

Specifying either --scan-threads, --scan-buffer, --scan-max-buffer or --copy-raw-zip results in the exception:

java.lang.NullPointerException: Cannot invoke "io.github.datromtool.cli.option.PerformanceOptions$ForceOptions.isForceUnrar()" because "this.forceOptions" is null
	at io.github.datromtool.cli.option.PerformanceOptions.merge(PerformanceOptions.java:169)
	at io.github.datromtool.cli.command.OneGameOneRomCommand.call(OneGameOneRomCommand.java:125)
	at io.github.datromtool.cli.command.OneGameOneRomCommand.call(OneGameOneRomCommand.java:45)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at io.github.datromtool.cli.DatRomCommand.main(DatRomCommand.java:31)

If --force-unrar is also specified these exceptions do not appear.

Specifying --copy-threads causes a different exception that is not fixed by --force-unrar:

java.lang.NullPointerException: threads is marked non-null but is null
	at io.github.datromtool.config.AppConfig$FileCopierConfig$FileCopierConfigBuilder.threads(AppConfig.java:55)
	at io.github.datromtool.cli.option.PerformanceOptions.merge(PerformanceOptions.java:185)
	at io.github.datromtool.cli.command.OneGameOneRomCommand.call(OneGameOneRomCommand.java:126)
	at io.github.datromtool.cli.command.OneGameOneRomCommand.call(OneGameOneRomCommand.java:45)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at io.github.datromtool.cli.DatRomCommand.main(DatRomCommand.java:31)
@andrebrait
Copy link
Owner

Thanks for reporting it.
I'll fix it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants