Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useecs: don't "fix" fields with expected_values #23

Open
andrewkroh opened this issue Jun 17, 2024 · 0 comments
Open

useecs: don't "fix" fields with expected_values #23

andrewkroh opened this issue Jun 17, 2024 · 0 comments
Labels
analyzer:useecs

Comments

@andrewkroh
Copy link
Owner

andrewkroh commented Jun 17, 2024 •
edited
Loading

Exempt ECS fields with expected_values from automatically being "fixed".

Some integrations avoid the ECS definition because it has a list of expected_values which are considered advisory (not mandatory), but elastic-package treats the list as the only acceptable values. So if the tool were to rewrite the field using external: ecs it could result in test failure.

Relates: elastic/integrations#10134 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
analyzer:useecs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewkroh