Incrementality of this generator is under the question.

[lsoft]

Sorry for disturbing you, I noticed about this problem about a week ago and I'm not sure I understand this correctly, but looks like this generator is not incremental at all.

Here I read that

 I think I know what tutorial you probably followed here, but I'm afraid it was just completely incorrect.
...
You should never have any compilations or symbols in any steps of your incremental pipelines, and especially in output steps.
Those objects are not equatable and not meant to be used this way.

blog-examples/NetEscapades.EnumGenerators3/src/NetEscapades.EnumGenerators/EnumGenerator.cs

Line 25 in b492595

IncrementalValueProvider<(Compilation, ImmutableArray<EnumDeclarationSyntax>)> compilationAndEnums

If I correct it would super cool to fix this place and update your tutorial. A lot of people follow that tutorial and obtain this error.

Again, I'm not sure I understand the things correctly. Sorry if I'm wrong.
Thanks!

[andrewlock]

Yikes, yeah, I wrote that series shortly after incremental generators were released, and noone really understood the requirements at the time 😬 I'm planning an updated blog post on these perf things anyway, so I'll prioritise updating those posts at the same time.

Thanks for the heads up!

[andrewlock]

FYI, I've just updated that post, and the example code in here 🙂 I would still recommend basing any generators you write off the "production" version here: https://github.com/andrewlock/NetEscapades.EnumGenerators but at least it's not so obviously broken now! 🤦‍♂️ Thanks