Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using 'Component' instead of 'PureComponent' #134

Open
SoYoung210 opened this issue Oct 8, 2018 · 0 comments
Open

using 'Component' instead of 'PureComponent' #134

SoYoung210 opened this issue Oct 8, 2018 · 0 comments

Comments

@SoYoung210
Copy link

sound-redux/client/src/components/Slider.jsx

Line 22 in 4d857b4

class Slider extends Component {

I think that usually PureComponent is much better than just Component in rendering performance when don't customize shouldComponentUpdate.

Component vs PureComponent in React
SoYoung210 added a commit to SoYoung210/sound-redux that referenced this issue Oct 8, 2018
@SoYoung210
[andrewngu#134] fix : Component To PureComponent
dd41867
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SoYoung210