Skip to content
This repository has been archived by the owner on Aug 15, 2023. It is now read-only.

Branch Master is not the starting point #1

Open
evowizz opened this issue Jun 14, 2020 · 1 comment
Open

Branch Master is not the starting point #1

evowizz opened this issue Jun 14, 2020 · 1 comment

Comments

@evowizz
Copy link

evowizz commented Jun 14, 2020

Hello there,

According to page #2 of the codelab, we are supposed to add Hilt to the project ourselves. However, as seen in the following lines, Hilt is already included in this project in Master.
https://github.com/googlecodelabs/android-dagger-to-hilt/blob/267db264888e8c76b9c6b54f663d9462fbb55e37/build.gradle#L5
https://github.com/googlecodelabs/android-dagger-to-hilt/blob/267db264888e8c76b9c6b54f663d9462fbb55e37/build.gradle#L13
https://github.com/googlecodelabs/android-dagger-to-hilt/blob/267db264888e8c76b9c6b54f663d9462fbb55e37/app/build.gradle#L9
https://github.com/googlecodelabs/android-dagger-to-hilt/blob/267db264888e8c76b9c6b54f663d9462fbb55e37/app/build.gradle#L71-L73

Moreover, this also prevent us from running the project at its starting point, because Hilt produces the following issue:

com\example\android\dagger\di\AppSubcomponents.java:7: error: [Hilt]
public final class AppSubcomponents {
             ^
  com.example.android.dagger.di.AppSubcomponents must also be annotated with @InstallIn.
  [Hilt] Processing did not complete. See error above for details
@lucasferreiramachado
Copy link

lucasferreiramachado commented Sep 17, 2021

Thanks @evowizz!
I submitted a pull request for this issue at #13.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants