-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WarningMessages to query response to be able to manage warnings #368
Comments
Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it. |
Hey @manuelbcd, Two questions:
Would love to review a PR for this! |
I have tested it on Jira Cloud but I think it is part of response (only when something goes wrong) in V3 API on-prem also You can check the response example in issue-search documentation: https://developer.atlassian.com/cloud/jira/platform/rest/v3/api-group-issue-search/ |
Great, thanks. Happy to review a PR for this. |
I'm worried my PR is breaking compatibility since I'm adding a warningMessages[] field to issue.Search() response. |
Thanks, @manuelbcd! I will have a look. Let us continue the discussion about the implementation approach to #369 |
Hey, I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma. However, there is news: We are kicking off v2 of this library 🚀To provide visibility, we created the Road to v2 Milestone and calling for your feedback in #489 The development will take some time; however, I hope you can benefit from the changes. What does this mean for my issue?We will work on this issue indirectly. Final wordsThanks for using this library. |
Is your feature request related to a problem? Please describe.
No, it is not a problem.
Describe the solution you'd like
When using Issue.Search(...) I have noticed that the optional field "WarningMessages" is not implemented in the response struct


struct:
real response (when something is wrong):
The drawback is that you are unable to detect these warnings since most of times the HTTP response is 200 even if one of the fields from the query is a wrong value (i.e. user not exists)
Describe alternatives you've considered
I think there are no alternatives.
Additional context
No additional context
@andygrunwald @benjivesterby what do you think? do you want me to implement it?
The text was updated successfully, but these errors were encountered: