Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enter deepEdit when enableCellEditOnFocus = true with F2 #7213

Open
rtavassoli opened this issue Feb 19, 2022 · 0 comments
Open

Cannot enter deepEdit when enableCellEditOnFocus = true with F2 #7213

rtavassoli opened this issue Feb 19, 2022 · 0 comments

Comments

@rtavassoli
Copy link

Hi, great job on the grid! I have a couple of issues, here is the first one. When enableCellEditOnFocus=true for the Grid you cannot enter deepEdit with the F2 key. Line 14368 of ui-grid.js is:

if (rowCol.row === $scope.row && rowCol.col === $scope.col && !$scope.col.colDef.enableCellEditOnFocus) {

The last condition will not let you enter deepEdit if already in (none deep-) editing mode due to enableCellEditOnFocus=true.

Event with enableCellEditOnFocus=true you sometimes want to enter deepEdit mode in order to be able to change the text by navigating inside the input control with the arrow keys, and not just overwriting the entire text. Grid Navigation will change cell focus with the arrow keys unless in deepEdit.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants