Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run the detailed example in plain Ruby project #6

Closed
olimart opened this issue Jul 29, 2019 · 1 comment
Closed

Can't run the detailed example in plain Ruby project #6

olimart opened this issue Jul 29, 2019 · 1 comment

Comments

@olimart
Copy link

olimart commented Jul 29, 2019

As always, very good stuff Andrew 👏

When running the detailed project in plain Ruby file, it breaks at the save section because of dependency loading/resolution.
uninitialized constant Eps::LinearRegression::Nokogiri

I noticed Nokogiri is declared only for dev. environment and don't know if you plan to keep as-is or maybe declare as top-level ::Nokogiri

ankane added a commit that referenced this issue Jul 29, 2019
@ankane
Copy link
Owner

ankane commented Jul 29, 2019

Thanks @olimart, I've added require "nokogiri" to the to_pmml method. I've considered making Nokogiri a runtime dependency of the gem, but it's only need for persisting models, so decided against it for now.

@ankane ankane closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants