Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyVault Network Rules #1026

Open
rasselmaliyekkal opened this issue Nov 17, 2022 · 6 comments · May be fixed by #1738
Open

KeyVault Network Rules #1026

rasselmaliyekkal opened this issue Nov 17, 2022 · 6 comments · May be fixed by #1738
Labels
has_pr PR fixes have been made medium_priority Medium priority

Comments

@rasselmaliyekkal
Copy link

Please raise issues via the new interface

I cannot find a network rule in keyvault mode, I'm stuck with deployment due to org level policy to restrict public access of keyvault.

cant find network rule property in this module:
https://docs.ansible.com/ansible/latest/collections/azure/azcollection/azure_rm_keyvault_module.html#ansible-collections-azure-azcollection-azure-rm-keyvault-module

@Fred-sun
Copy link
Collaborator

@rasselmaliyekkal You mean we need to add a module in order to add network rules to the keyvault module! right?

@Fred-sun Fred-sun added the work in In trying to solve, or in working with contributors label Nov 22, 2022
@rasselmaliyekkal
Copy link
Author

@Fred-sun - Yes

@Fred-sun
Copy link
Collaborator

@rasselmaliyekkal I'm sorry for replying you so late. The SDK does not support the creation of 'keyvault Network rules' for the time being. It cannot be added once it is supported. We will consider adding this support! Thanks!

@Fred-sun Fred-sun added new_module_issue Request to add a new module hold The problem holds for a particular reason and removed work in In trying to solve, or in working with contributors labels Nov 30, 2022
@michie1
Copy link

michie1 commented Oct 8, 2024

@Fred-sun What do you mean with "It cannot be added once it is supported."? Do you mean "It can be added"?
How to check if the SDK already supports it now we are a couple of years further?

@Fred-sun
Copy link
Collaborator

Fred-sun commented Oct 8, 2024

@michie1 Yes, this problem has been held for some time. I will check whether the latest SDK supports it and add it as soon as possible. Thank you!

@Fred-sun Fred-sun linked a pull request Oct 10, 2024 that will close this issue
@Fred-sun Fred-sun added has_pr PR fixes have been made medium_priority Medium priority and removed new_module_issue Request to add a new module hold The problem holds for a particular reason labels Oct 10, 2024
@Fred-sun
Copy link
Collaborator

@michie1 @rasselmaliyekkal Added in #1738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has_pr PR fixes have been made medium_priority Medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants